Add re_max_angle_error to configuration and improve track merging logic#48
Draft
zitongzhan wants to merge 2 commits into
Draft
Add re_max_angle_error to configuration and improve track merging logic#48zitongzhan wants to merge 2 commits into
zitongzhan wants to merge 2 commits into
Conversation
zitongzhan
commented
Apr 2, 2026
| num_changed_observations += retriangulate_underreconstructed_pairs( | ||
| view_graph, cameras, images, tracks, TRIANGULATOR_OPTIONS, pair_retry_counts | ||
| num_changed_observations += abs( | ||
| complete_and_merge_tracks(view_graph, cameras, images, tracks, tracks_orig, TRIANGULATOR_OPTIONS) |
Collaborator
Author
There was a problem hiding this comment.
The complete and merge tracks is added, but the retriangulate_underreconstructed_pairs is removed. This need KPI validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors to the track completion and merging logic in the
track_retriangulation.pymodule. The changes enhance track merging, observation completion, and correspondence handling, as well as configurable options for error thresholds.Key improvements and refactors include:
Track Merging and Correspondence Handling
merge_tracksfunction to use view graph correspondences for merging, ensuring only tracks with valid feature correspondences are considered. The merging logic now uses a union-find data structure and updates track ownership for merged observations, increasing merge accuracy and efficiency. [1] [2]_build_correspondence_lookuphelper function to efficiently map feature correspondences from the view graph, enabling more precise and robust track merging.Observation Completion and Validation
complete_tracksfunction to avoid duplicating observations, prevent cross-track conflicts, and only add valid observations, using a new_obs_tuplehelper for observation identity. [1] [2] [3]_point_angular_reprojection_is_valid), controlled by a newre_max_angle_errorthreshold in the configuration. [1] [2] [3] [4]Configuration and API Updates
re_max_angle_errorparameter to the COLMAP configuration for finer control over angular error during observation validation.view_graphparameter for functions that depend on feature correspondences, such asmerge_tracksandcomplete_and_merge_tracks. [1] [2] [3]enable_mergeflag in the triangulator options.