Upgrade JavaScript code Using ES6 Concepts#167
Upgrade JavaScript code Using ES6 Concepts#167Keerthivardhan1 wants to merge 8 commits intocreativecommons:mainfrom
Conversation
|
Coming to Google Analytics, According to my understanding that part of code is already optimized. It just need to be documented. I did that. Thank you. |
adidevs
left a comment
There was a problem hiding this comment.
Hey @Keerthivardhan1 ! These are good changes to the repository but as you might have noticed that the current state of your branch has merge conflicts with the base branch.
This is because your fork might not have been synced after the recent PRs that have been merged. Your code is missing those changes and thus the conflicts.
To solve this, kindly sync your fork of this repository and fetch - pull changes in your local dev environment, then modify the JS code appropriately. For starters, you can convert this to a draft PR so that the maintainers know that your are actively working on it.
|
@adidevs, Now I think there is no merge conflicts. I resolved them. can you please review this PR. |
This commit changes UpdateQueryString() and RemoveQueryString() funcion to initial stage.
adidevs
left a comment
There was a problem hiding this comment.
@Keerthivardhan1 , one minor change left.
Fixes
Fixes #110 by @keerthivardhan
Description
This PR Optimizes the JavaScript code using ES6 Concepts
Technical details
This code uses : -
Arrow Functions.
Template literals.
Destructuring.
const instead of let . . .
and required Documentation.
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin