fix: used protocolversion 2 for indy flows

[RinkalBhojani]

#What?

• Using protocolVersion V2 by default for Indy issuance and verification

#Why?

• Mobile wallet has already migrated to protocol version v2 and it was breaking the flow

Summary by CodeRabbit

• Documentation

  • API documentation examples updated to reflect protocol version v2.

• Updates

  • Credential issuance now defaults to protocol version v2 (previously v1).
  • Proof verification now defaults to protocol version v2 (previously v1).

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: babf289f-fbcb-4a0b-8044-fdb3eece9259

📥 Commits

Reviewing files that changed from the base of the PR and between 921c73c and 2126f64.

📒 Files selected for processing (5)

• apps/api-gateway/src/dtos/credential-offer.dto.ts
• apps/api-gateway/src/dtos/issue-credential.dto.ts
• apps/api-gateway/src/issuance/dtos/issuance.dto.ts
• apps/issuance/src/issuance.service.ts
• apps/verification/src/verification.service.ts

---

📝 Walkthrough

Walkthrough

This PR upgrades the default protocol version from v1 to v2 throughout the credential issuance and verification workflows. Swagger API documentation examples are updated in five DTO files, and the runtime defaults for credential offer generation and proof request creation are changed across the issuance and verification services.

Changes

Protocol Version v1 to v2 Upgrade

Layer / File(s)	Summary
API Gateway DTO Swagger Examples apps/api-gateway/src/dtos/credential-offer.dto.ts, apps/api-gateway/src/dtos/issue-credential.dto.ts, apps/api-gateway/src/issuance/dtos/issuance.dto.ts	Swagger decorator example values for protocolVersion in IssueCredentialOffer, IssueCredentialDto, CredentialsIssuanceDto, and OOBCredentialDtoWithEmail changed from v1 to v2; formatting normalized in attribute examples.
Issuance Service Credential Offer Defaults apps/issuance/src/issuance.service.ts	Default protocolVersion updated from v1 to v2 in sendCredentialCreateOffer, sendCredentialOutOfBand, and sendEmailForCredentialOffer methods when protocol version is not explicitly provided.
Verification Service Proof Request Defaults apps/verification/src/verification.service.ts	Default protocolVersion updated from PROTOCOL_VERSION_1 to PROTOCOL_VERSION_2 in sendProofRequest, and from v1 to v2 in sendOutOfBandPresentationRequest when protocol version is not explicitly provided.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• ankita-p17
• tipusinghaw

Poem

A rabbit hops through versions new,
From v1's old path to v2's true blue,
Through DTOs and services it goes,
The protocol upgrades in stately rows! 🐰✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately describes the main change: updating Indy flows to use protocol version 2 by default.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/use-prototocolversion2-indy

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}