fix: split buildtest into a unit-test pass and a separate benchmark pass#724
Merged
Merged
Conversation
credfeto
changed the title
credfeto
changed the title
credfeto
marked this pull request as ready for review
July 16, 2026 08:56
…s dotnet test invocation Some benchmark test projects' test host rejects these as invalid arguments (exit code 5, "Zero tests ran") instead of running, confirmed by direct reproduction against FunFair.Ethereum.DataTypes.Benchmark.Tests. Removing --parallel-algorithm aggressive also addresses part of the OOM racing problem tracked in #679. Closes #723
Mirrors credfeto-global-pre-commit's src/scripts/buildtest design: the main dotnet test run now always excludes every benchmark test project (keeping --long-running/--parallel-algorithm aggressive, safe now that benchmarks aren't mixed in), and any benchmark projects found are run individually afterwards, one dotnet test invocation per project, without those two flags - some benchmark projects' test host rejects them as invalid arguments. Also fixes the -b/--no-benchmmarks flag's broken unquoted TEST_BENCHMARKS assignment, which is now load-bearing for skipping the new benchmark phase. Refs #679
credfeto
force-pushed
the
fix/723-buildtest-remove-invalid-test-flags
branch
from
July 16, 2026 08:57
080bffe to
6e022f5
Compare
Owner
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
development/buildtestnow mirrorscredfeto-global-pre-commit'ssrc/scripts/buildtestdesign: the maindotnet testrun always excludes every benchmark test project (keeping--long-running/--parallel-algorithm aggressive, which is safe now that benchmarks aren't mixed in), and any benchmark projects found are run individually afterwards, onedotnet testinvocation per project, without those two flags.FunFair.Ethereum.DataTypes.Benchmark.Tests) rejects--long-running/--parallel-algorithmas invalid command-line arguments, producing exit code 5 ("Zero tests ran") instead of actually running. Confirmed by direct reproduction: the identical invocation without those flags passed 4/4 tests in 4m20s.-b/--no-benchmmarksflag's broken unquotedTEST_BENCHMARKSassignment (previously a no-op), which is now load-bearing for skipping the new benchmark phase.credfeto-global-pre-commit'ssrc/scripts/buildtestas the source of truth for this design, so the two stay in sync.Closes #723
Refs #679
How Has This Been Tested
shellcheck --shell=shpasses on the modified script.checkbashismspasses on the modified script.Types of changes
Checklist