Skip to content

Cipher tests run using typescript port of tinyaes#10

Open
numtel wants to merge 2 commits into
crema-labs:mainfrom
numtel:tinyaes-ts
Open

Cipher tests run using typescript port of tinyaes#10
numtel wants to merge 2 commits into
crema-labs:mainfrom
numtel:tinyaes-ts

Conversation

@numtel

@numtel numtel commented Jan 18, 2025

Copy link
Copy Markdown

Hello,

Thanks for making this project! I was reading through the code and noticed that there was no way to generate the ciphertexts from the typescript tests since the reference tinyaes implementation is rust so I had ChatGPT write an implementation in typescript and integrated it into the cipher tests.

Comment thread tinyAes.ts Outdated
@Nesopie

Nesopie commented Jan 19, 2025

Copy link
Copy Markdown
Member

Hi @numtel, thank you for the PR! node.js already has an inbuilt aes implementation in their crypto module cf: https://nodejs.org/api/crypto.html#class-cipher

@numtel

numtel commented Jan 19, 2025

Copy link
Copy Markdown
Author

Ah good catch, the node.js crypto module does support this aes mode. I was thinking about how to incorporate this circuit into a web app so it made sense to use the browser api. I'll update this so it uses the node api instead.

@numtel

numtel commented Jan 19, 2025

Copy link
Copy Markdown
Author

Ok updated and the decrypt function now works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants