Cipher tests run using typescript port of tinyaes#10
Open
numtel wants to merge 2 commits into
Open
Conversation
numtel
commented
Jan 18, 2025
Member
|
Hi @numtel, thank you for the PR! node.js already has an inbuilt aes implementation in their crypto module cf: https://nodejs.org/api/crypto.html#class-cipher |
Author
|
Ah good catch, the node.js crypto module does support this aes mode. I was thinking about how to incorporate this circuit into a web app so it made sense to use the browser api. I'll update this so it uses the node api instead. |
Author
|
Ok updated and the decrypt function now works :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for making this project! I was reading through the code and noticed that there was no way to generate the ciphertexts from the typescript tests since the reference tinyaes implementation is rust so I had ChatGPT write an implementation in typescript and integrated it into the cipher tests.