Add separate -TMD parallelization tag for the MTD stage - #490
Open
MakarSaviak wants to merge 3 commits into
Open
Add separate -TMD parallelization tag for the MTD stage#490MakarSaviak wants to merge 3 commits into
MakarSaviak wants to merge 3 commits into
Conversation
Author
|
While validating this PR, I found a separate mismatch between the documented iMTD-GC behavior and the compiled nonlegacy implementation. The CREST literature states that, when a lower-energy conformer is found, the procedure is restarted from that conformer. In the code, CREGEN correctly updated The two latest commits resolve this by refreshing call env%ref%to(mol) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a small -T / parallel MTD CPU allocation issue in CREST 3.0.1 and made a minimal fix here.
In my CREST-NCI/GFN-FF tests, a large -T value was useful for the post-processing stage, but it also slowed down the MTD stage because the parallel MTD workers were not assigned CPU resources cleanly. This small fix adds an additional -TMD flag, allowing the number of CPU resources used for the MTD stage to be set separately from the global -T value. Since 3.1.0 is still being finalized, maybe this logic would be useful to port into the refactor.
For example, in my case -T 128 significantly accelerated post-processing because many conformers had to be handled, but it increased the MTD runtime from a few hours to days. On the other hand, -T 6 was optimal for running 6 GFN-FF MTD trajectories, but too slow for the conformer post-processing step. With the separate -TMD flag, both stages can use more appropriate CPU settings.