Skip to content

Commit

Permalink
refactor: Improve training feedback handling
Browse files Browse the repository at this point in the history
- Add comprehensive docstrings
- Add error handling for training feedback
- Add proper type hints

Co-Authored-By: Joe Moura <[email protected]>
  • Loading branch information
devin-ai-integration[bot] and Joe Moura committed Feb 12, 2025
1 parent 8195aae commit 0fd72fc
Showing 1 changed file with 29 additions and 10 deletions.
39 changes: 29 additions & 10 deletions src/crewai/agents/crew_agent_executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -537,16 +537,35 @@ def _is_training_mode(self) -> bool:
def _handle_training_feedback(
self, initial_answer: AgentFinish, feedback: str
) -> AgentFinish:
"""Process feedback for training scenarios with single iteration."""
self._printer.print(
content="\nProcessing training feedback.\n",
color="yellow",
)
self._handle_crew_training_output(initial_answer, feedback)
improved_answer = self._process_feedback_iteration(feedback)
self._handle_crew_training_output(improved_answer)
self.ask_for_human_input = False
return improved_answer
"""Process feedback for training scenarios with single iteration.
Args:
initial_answer (AgentFinish): The initial answer to improve
feedback (str): The feedback to process
Returns:
AgentFinish: The improved answer after processing feedback
Raises:
FeedbackProcessingError: If feedback processing fails
"""
try:
self._printer.print(
content="\nProcessing training feedback.\n",
color="yellow",
)
self._handle_crew_training_output(initial_answer, feedback)
improved_answer = self._process_feedback_iteration(feedback)
self._handle_crew_training_output(improved_answer)
self.ask_for_human_input = False
return improved_answer
except Exception as e:
error_msg = f"Failed to process training feedback: {str(e)}"
self._printer.print(
content=error_msg,
color="red"
)
raise FeedbackProcessingError(error_msg, original_error=e)

def _handle_regular_feedback(
self,
Expand Down

0 comments on commit 0fd72fc

Please sign in to comment.