Support Python 3.13

[lucasgomide]

Closes #1687

[joaomdmoura]

Disclaimer: This review was made by a crew of AI Agents.

Code Review Comment for PR #2844

Summary

This PR introduces essential enhancements to the crewAI project, focusing on dependency management through version updates, updates to CI configurations, and necessary documentation adjustments. Here are the key areas requiring further attention and improvement:

Dependency Version Upgrades

The following critical updates have been made in pyproject.toml:

1. Python Version Specification:

   • Changed from >=3.10,<3.13 to >=3.10,<=3.13. This change should be clearly noted as it now explicitly includes Python 3.13, enhancing clarity on supported versions.

2. Major Upgrades of Dependencies:

   • fastembed: Upgraded from v0.4.1 to v0.7.0
   • onnxruntime: Upgraded from v1.19.2 to v1.22.0
   • numpy: A transitive dependency upgrade from v1.26.4 to v2.2.5
   • Note: Removal of onnx v1.17.0 as it is no longer necessary.

Recommendations for Dependency Management:

• It would be prudent to impose explicit upper bounds on the critical dependencies to prevent compatibility issues in the future. For instance:

  [project.dependencies]
  fastembed = ">=0.7.0,<0.8.0"
  onnxruntime = ">=1.22.0,<2.0.0"

CI Configuration Changes

• The CI configuration has been updated to include Python 3.13 in the test matrix, which is commendable. However, it’s important to ensure thorough testing across all supported Python versions.

Documentation Updates

• The documentation correctly reflects new Python version support. However, we recommend enhancing the commit messages to provide context about breaking changes in the upgraded dependencies as follows:

  feat: upgrade fastembed & onnxruntime
  
  The following dependencies were upgraded:
  1. fastembed: v0.4.1 -> v0.7.0
     - Release notes: [link]
     - Breaking changes: [summary]
  2. onnxruntime: v1.19.2 -> v1.22.0
     - Release notes: [link]
  3. numpy: v1.26.4 -> v2.2.5 (transitive dependency)
     - Impact analysis: [summary]
  
  Removed dependencies:
  - onnx v1.17.0 (no longer needed)
  
  Testing:
  - Compatibility verified across Python versions 3.10-3.13
  - Full test suite executed with updated dependencies
  

Testing Implications

• Specific tests validating compatibility with Python 3.13 and integration tests around the fastembed and onnxruntime functionality should be included.
• Document any known issues or limitations arising from the Python 3.13 updates.

Security Considerations

• Ensure that the security advisories for the newly upgraded dependencies are reviewed. Verify that there are no known vulnerabilities in the newer packages.
• If a SECURITY.md file is absent, consider creating one to align with best practices.

Conclusion

The PR contains essential updates with respect to dependency management and documentation alignment that significantly improve the project’s clarity regarding support for Python 3.13. Overall, the changes are well-structured. However, addressing the recommendations stated above will enhance code quality and ensure a robust and maintainable codebase for future development.

Action Required Before Merging:

1. Introduce specific version upper bounds for critical dependencies.
2. Enhance commit messages with detailed changelog information.
3. Validate test coverage for Python 3.13.
4. Confirm there are no breaking changes introduced by the dependency upgrades.

Looking forward to seeing these adjustments made!

[lorenzejay]

i feel like we can drop this? no files use this, outside of fastembed.py but nothing is using it iirc

[lucasgomide]

That's awesome! I'm going to double check that

[lorenzejay]

lfg