fix(llm): isolate caller file messages - #6968
Open
ump45nose wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChangesLLM message copy handling
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ump45nose
marked this pull request as ready for review
August 12, 2026 06:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copy caller-supplied message dictionaries before LiteLLM file formatting can replace content or remove the
filesfield.Root cause
The LiteLLM sync and async paths passed the caller's message dictionaries directly to their file-processing helpers, which mutate those dictionaries. Reusing the same message list therefore dropped attachments after the first call.
Validation
uv run --with litellm --with anthropic pytest lib/crewai/tests/test_llm.py -k "does_not_mutate_file_messages" -quv run ruff format --check lib/crewai/src/crewai/llm.py lib/crewai/tests/test_llm.pyuv run ruff check lib/crewai/src/crewai/llm.py lib/crewai/tests/test_llm.py