Fixes lint issues for a green build #589
Open
+115
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the default paths and adds all .go files in the example directory.
|
There seem to be a year and a half of pull requests open, some serious (like the jawt vuln). Would someone like to create and own a fork? The owner's http://crewjam.com is gone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades golangci-lint to v2 and migrates the configuration in .golangci.yml to newer format.
The migration itself was done with
golangci-lint migratewhich hopefully preserves as much functionality as possible. I've modified the configuration file to exclude the files under example/The rest of the changes are addressing issues found by the linters after the migration.
I've kept the commits separate in the pull request to make it easier to review, or to reject individual lint fixes. Let me know if you want me to squash to one commit.