Conversation
Remove develop staging branch. Project will now use rebase or squash merging strategies for Pull Requests.
crgnam
force-pushed
the
ci_dev
branch
5 times, most recently
from
fab230a to
98bcf85
Compare
This commit adds automated testing of the conda package to ensure that
downstream users can successfully use vira via find_package(vira).
CI/Workflow Changes:
- Rename build.yml to ci-cd.yml (and workflow name to "CI/CD Pipeline")
- Restrict workflow to only run on main branch and PRs to main
- Add conda-test-{linux,macos,windows} jobs that build a minimal test
project against the installed conda package
- Use artifacts to pass built conda packages between build and test jobs
- Configure proper conda environment activation in test jobs
- Fix Windows local channel path using cygpath for proper file:// URLs
- Add "CI" gate job that depends on all other jobs for simplified
branch protection (only need to require single "CI" status check)
Conda Recipe Fixes (dependencies/recipe/):
- Add explicit CMAKE_INSTALL_PREFIX to build.sh and bld.bat
- Disable optional build targets (tools, examples, tests, scratch, docs)
- Add all development dependencies to run requirements (header-only
library requires -devel packages for downstream compilation)
- Add cmake config file existence tests to meta.yaml
CMake Package Configuration Fixes:
- Rename config files to lowercase (viraConfig.cmake, viraTargets.cmake)
for proper find_package(vira) discovery
- Add VIRA_INSTALL_CMAKEDIR to PATH_VARS in configure_package_config_file
- Add missing find_dependency calls for indicators, plog, termcolor, cspice
- Install ViraFetch*.cmake helpers for downstream dependency resolution
- Create stb::stb target before including viraTargets.cmake
CMake Install Fixes:
- Install ViraFetch{Indicators,Plog,Termcolor,CSPICE}.cmake helper modules
to allow downstream projects to find dependencies
- Fix ViraFetchSTB.cmake to install headers to include root (not stb/
subdirectory) to match build-time include paths
Test Infrastructure:
- Add tests/packaging/CMakeLists.txt with minimal find_package test
- Add tests/packaging/main.cpp that includes vira/vira.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An overhaul of the CI/CD pipeline to include conda packaging.