#105 Add ability to set custom client id from UI#115
Merged
cricketthomas merged 2 commits intomasterfrom Mar 24, 2025
Merged
Conversation
- Introduced `SettingsPageClientIdCheckbox` and `CustomClientId` properties in `AppSettings`. - Updated `AuthService` to use these new settings for authentication. - Enhanced `SettingsPageViewModel` with observable properties for the new settings. - Modified settings retrieval to include the new properties from JSON. - Implemented partial methods to handle changes to the new settings asynchronously. - Updated XAML to include UI elements for custom client ID configuration.
cricketthomas
force-pushed
the
105-add-custom-clientid
branch
from
877134c to
b7897c9
Compare
GSerjo
approved these changes
Mar 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New feature implementation for enhanced client ID management in the UI, allowing users to use their own enterprise applications, rather than mine from my own tenant. Users will navigate to the settings page, click the checkbox, and add their valid client/application id.
This implementation has been added in the new version, and has been added to this version as well until the new version is ready.
This should close #105
PR Summary
This pull request introduces new properties for managing custom client IDs in the application settings and updates the UI to support these features. It also includes package updates for improved functionality and performance.
AppSettings.cs: AddedSettingsPageClientIdCheckboxandCustomClientIdproperties.AuthService.cs: Modified constructor to utilize the new client ID properties.SettingsPageViewModel.cs: Enhanced with observable properties for the new settings and their change handlers.SettingsPage.axaml: Updated layout to include a settings expander for custom client ID input.README.md: Revised to provide instructions for using a custom client ID/application ID in Azure AD.