Some more fixes for v21 #683
Conversation
| if (isRunningOnManager) { | ||
| setOf( | ||
| ResourceGroup("values-ja", "strings.xml", "arrays.xml"), | ||
| ).forEach { | ||
| replaceStringsInFile( | ||
| it, | ||
| replacements = | ||
| mapOf( | ||
| "X" to "Twitter", | ||
| "ポスト" to "ツイート", | ||
| ), | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
String replacement for Japanese is only run when isRunningOnManager
There was a problem hiding this comment.
Also, setOf ~ forEach is no longer needed
There was a problem hiding this comment.
lol I thought, isRunningOnManager is required here as well, will correct it, thanks
|
It is reported that Possible solutions:
Alternatively, this pull request could be merged as-is, and fix in another PR |
ya I have handled it here Utils.kt#L80 |
2 participants
No description provided.