Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /page/:page routes for 2025 theme #4249

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

veganstraightedge
Copy link
Contributor

Most notable change is:

Before
in 2017 theme, routes like /page/2 were handled by home#index
They were the homepage with a different collection of articles, and no "latest article"

Now
in 2025 theme, routes like /page/2 are handled by articles#index
They are the same article_archives#index

So, in the transitional time from 2017 theme to 2025, the articles#index controller action receives the /page/2 request, then does the same setup and render as home#index (literally copy/pasted from home#index)

After the transition is launched and announced, we can delete all of the double dispatch code

@veganstraightedge veganstraightedge marked this pull request as ready for review January 16, 2025 10:21
@veganstraightedge veganstraightedge merged commit 110a998 into main Jan 16, 2025
9 checks passed
@veganstraightedge veganstraightedge deleted the 2025_artcicles_page_2 branch January 16, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant