Fix /page/:page routes for 2025 theme #4249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most notable change is:
Before
in 2017 theme, routes like
/page/2
were handled byhome#index
They were the homepage with a different collection of articles, and no "latest article"
Now
in 2025 theme, routes like
/page/2
are handled byarticles#index
They are the same
article_archives#index
So, in the transitional time from 2017 theme to 2025, the
articles#index
controller action receives the/page/2
request, then does the same setup and render ashome#index
(literally copy/pasted fromhome#index
)After the transition is launched and announced, we can delete all of the double dispatch code