Implementing Class and Datatype discovery #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following changes have been made: * adding necessary types including datatype and class descriptor types and types allowing constraints * for struct datatypes we now have a get_type_descriptor used by the Class Manager * add the intermediate NcManager entitiy and updated NcDeviceManager to be based on it instead of directly from NcObject * all classes based on NcObject now offer a get_class_descriptor used by the Class Manager * add a new Class Manager entity used for datatype and class descriptor discovery via properties or methods * instantiate the new class manager in main inside the root block * the root block no longer offers itself in the results of find_members_by_class_id * added better validation for message handles which now send an Error message when invalid * tweak various edge cases so they respond with more appropriate statuses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes have been made: