Fix consul lib semaphore #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous patch didn't actually fix the root cause. Issue was that we were not in the same context, therefore @options param doesn't exist in class Semaphore. Fix consists on instead passing the actual parameter instead of the whole options hash.
mougams
force-pushed
the
fix_consul_lock
branch
from
32c289f to
11e6b34
Compare
jlundqvist-criteo
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous patch didn't actually fix the root cause. Issue was that we were not in the same context, therefore @options param doesn't exist in class Semaphore.
Fix consists on instead passing the actual parameter instead of the whole options hash.