Added support for gRPC streaming of large files #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should eventually remove old "Sign" and "Decrypt" endpoints and keep using only the streaming version to stay consistent and to avoid maintaining 2 endpoints that do almost the same thing. Streaming is preferred over the classic gRPC request as it allows us to bypass max gRPC message size limitation, by chunking the request (like image or PDF upload) into smaller parts that don't struggle with gRPC limitations.
First, let's merge this PR while keeping old Sign and Decrypt endpoints. Once its merged, we can create a new PR where we will remove the old endpoints - this is to keep client and server protobuf definition in sync.
Also, since I am not a Rust developer, please take a look at the Rust code in this PR and check if it does not violate any standards etc @MarekMracna. The current version is working but could probably by improved.
Note:
This protobuf definition is compatible with meesign-client in the grpc-streaming branch.