Skip to content

fix: Stack컴포넌트 forwardRef롤백 및 import ./Stack.css 임시 주석 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Obj277 merged 2 commits into from
Jun 30, 2025
Merged

fix: Stack컴포넌트 forwardRef롤백 및 import ./Stack.css 임시 주석 #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ded0d6
fix: forwardRef롤백 및 import ./Stack.css 임시 주석
Obj277 Jun 30, 2025
c65c8a3
chore: changeset
Obj277 Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/plenty-kids-sleep.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@croquiscom/monolith': patch
---

Stack컴포넌트 forwardRef 복구 및 import css주석 처리
101 changes: 54 additions & 47 deletions src/components/stack/Stack.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { PropsWithChildren, CSSProperties, HTMLAttributes } from 'react';
import './Stack.css';
import { PropsWithChildren, CSSProperties, HTMLAttributes, forwardRef } from 'react';
// import './Stack.css'; // 임시 주석 처리
import { buildFlexClassNames } from './utils/buildFlexClassNames';

/** The props type of {@link Stack | 'Stack'}. */
Expand Down Expand Up @@ -86,50 +86,57 @@ export interface StackProps extends PropsWithChildren {
* </Stack>
* ```
*/
export const Stack = ({
children,
className,
direction,
wrap,
align,
justify,
gap,
width,
height,
m,
mt,
ml,
mr,
mb,
p,
pt,
pl,
pr,
pb,
...props
}: StackProps & HTMLAttributes<HTMLDivElement>) => {
const flex_classes = buildFlexClassNames({ direction, wrap, align, justify });
const combined_classes = [flex_classes, className].filter(Boolean).join(' ');
export const Stack = forwardRef<HTMLDivElement, StackProps & HTMLAttributes<HTMLDivElement>>(
(
{
children,
className,
direction,
wrap,
align,
justify,
gap,
width,
height,
m,
mt,
ml,
mr,
mb,
p,
pt,
pl,
pr,
pb,
...props
},
ref,
) => {
const flex_classes = buildFlexClassNames({ direction, wrap, align, justify });
const combined_classes = [flex_classes, className]
.filter((cls) => cls && typeof cls === 'string' && cls.trim() !== '')
.join(' ');

const spacing_style: CSSProperties = {
...(gap !== undefined && { gap }),
...(width !== undefined && { width }),
...(height !== undefined && { height }),
...(m !== undefined && { margin: m }),
...(mt !== undefined && { marginTop: mt }),
...(ml !== undefined && { marginLeft: ml }),
...(mr !== undefined && { marginRight: mr }),
...(mb !== undefined && { marginBottom: mb }),
...(p !== undefined && { padding: p }),
...(pt !== undefined && { paddingTop: pt }),
...(pl !== undefined && { paddingLeft: pl }),
...(pr !== undefined && { paddingRight: pr }),
...(pb !== undefined && { paddingBottom: pb }),
};
const spacing_style: CSSProperties = {
...(gap !== undefined && { gap }),
...(width !== undefined && { width }),
...(height !== undefined && { height }),
...(m !== undefined && { margin: m }),
...(mt !== undefined && { marginTop: mt }),
...(ml !== undefined && { marginLeft: ml }),
...(mr !== undefined && { marginRight: mr }),
...(mb !== undefined && { marginBottom: mb }),
...(p !== undefined && { padding: p }),
...(pt !== undefined && { paddingTop: pt }),
...(pl !== undefined && { paddingLeft: pl }),
...(pr !== undefined && { paddingRight: pr }),
...(pb !== undefined && { paddingBottom: pb }),
};

return (
<div className={combined_classes} style={spacing_style} {...props}>
{children}
</div>
);
};
return (
<div ref={ref} className={combined_classes} style={spacing_style} {...props}>
{children}
</div>
);
},
);