Fix 1771 complete#1774
Merged
oberstet merged 3 commits intocrossbario:masterfrom Nov 24, 2025
Merged
Conversation
This commit completes FlatBuffers serialization support for the remaining WAMP messages: - Category 3 (Forwarding Only): Cancel, Interrupt, EventReceived - Category 1 (Session Lifecycle): Hello, Welcome - Category 1 (RPC): Unregister Changes: - Fixed Cancel, Interrupt build() methods to handle forward_for and remove non-existent session references - Fixed EventReceived build() to wrap in Message union - Added build() and cast() methods for Unregister - Fixed Hello and Welcome build() methods to wrap in Message union - Added MESSAGE_TYPE_MAP entries for Hello and Welcome - Enhanced test vector generator to: - Support EVENT_RECEIVED message type - Convert dict roles to RoleFeatures instances for Hello/Welcome Test results: 529 passed, 0 skipped, 12 warnings Note: This work was completed with AI assistance (Claude Code).
Update wamp-proto submodule to commit 2fcf809 which includes FlatBuffers test vectors for the remaining WAMP messages (Cancel, Interrupt, EventReceived, Hello, Welcome, Unregister). This completes FlatBuffers test coverage with 529 tests passing, 0 skipped. Note: This work was completed with AI assistance (Claude Code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the missing commits from #1773 that were not included in the squash merge.
The original PR was merged before the final 2 commits were pushed to GitHub, resulting in incomplete FlatBuffers support.
What This Adds
Commit 1: Add FlatBuffers support for remaining WAMP messages
Commit 2: Bump .proto submodule
Impact Without These Changes
Impact With These Changes
Testing