Phase 1.2: Build Tooling Modernization#1788
Merged
oberstet merged 11 commits intocrossbario:masterfrom Dec 2, 2025
Merged
Conversation
oberstet
changed the title
…ysis Document NULL pointer dereference issue reported by University of Athens researchers and provide comprehensive analysis of effort required to rewrite NVX module in Rust. Issue crossbario#1789: Simple fix (< 1 hour) - add NULL checks after malloc Rust rewrite: 2-3 weeks effort - eliminates entire class of bugs Recommendation: Fix crossbario#1789 in Phase 1.2, consider Rust rewrite later. Note: This work was completed with AI assistance (Claude Code).
- Add project header banner to justfile default recipe - Add clean-build recipe to remove build artifacts - Add verify-wheels recipe with twine check and auditwheel validation - Add docstring to docs-view recipe Part of GitHub issue crossbario#1789 (Phase 1.2 Build Tooling Modernization). Note: This work was completed with AI assistance (Claude Code).
Added recipes: - fix-format: renamed from autoformat (autoformat kept as alias) - test-all: run tests on all environments - upgrade: upgrade dependencies in single environment - upgrade-all: upgrade dependencies in all environments These recipes align autobahn-python with the common justfile recipes specification defined in MODERNIZATION.md for consistent developer experience across the WAMP Python ecosystem. Note: This work was completed with AI assistance (Claude Code).
- Move autobahn/, flatbuffers/, twisted/ packages to src/ directory - Update pyproject.toml for src layout with where = ["src"] - Update docs/conf.py autoapi_dirs to point to src/autobahn - Update .ai submodule to latest (3d10240) with audit docs - Create docs/ai/ subfolder with symlinks to .ai submodule - Update docs/index.rst to reference ai/ subfolder Note: This work was completed with AI assistance (Claude Code).
- Update paths from autobahn/nvx/ to src/autobahn/nvx/ - Add detailed comment explaining why setup.py is still needed (CFFI has no pyproject.toml support for cffi_modules) Note: This work was completed with AI assistance (Claude Code).
- Update mypy.ini python_version from 3.7 to 3.11 - Update justfile paths from autobahn/ to src/autobahn/ - check-typing mypy path - check-coverage-asyncio pytest paths - test-asyncio pytest paths - clean-fbs, build-fbs FlatBuffers paths Note: This work was completed with AI assistance (Claude Code).
The _utf8validator.c and _xormasker.c files are needed at runtime for CFFI to compile the native extensions. Note: This work was completed with AI assistance (Claude Code).
With src layout, tests run from src/ directory. Using non-editable install copies files to site-packages, causing pytest to find both locations and fail with "import file mismatch". Changed all test/check recipes to use install-dev (editable mode) instead of install (non-editable): - check-typing, check-coverage-*, check-coverage - test-import, test-twisted, test-asyncio, test-serdes - wstest-testeeclient-*, wstest-testeeserver-* Note: This work was completed with AI assistance (Claude Code).
Note: This work was completed with AI assistance (Claude Code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1787
Related Issue(s)
Closes or relates to #1787
Checklist
the style guidelines of this project
is effective or that my feature works
updated the changelog
in this PR