Skip to content

skiplist: a new iteator which is sendable among threads#1091

Open
SpadeA-Tang wants to merge 7 commits intocrossbeam-rs:masterfrom
SpadeA-Tang:sendable-iterator
Open

skiplist: a new iteator which is sendable among threads#1091
SpadeA-Tang wants to merge 7 commits intocrossbeam-rs:masterfrom
SpadeA-Tang:sendable-iterator

Conversation

@SpadeA-Tang
Copy link
Copy Markdown

Ref #1090

This PR implements a wrapper of the skiplist which supports creating iteator that is sendable among threads.
More tests or comment can be added if this is needed.

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
/// A lock-free skip list.
pub struct ConcurrentSkipList<K, V> {
/// The underlying skip list
list: Arc<SkipList<K, V>>,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reply. It's a bit late here, I will see it tomorrow.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified the code. PTAL again, thanks @taiki-e . If this is desired, I will add more tests.

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
@SpadeA-Tang SpadeA-Tang requested a review from taiki-e March 12, 2024 03:10
u
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants