skiplist: a new iteator which is sendable among threads#1091
Open
SpadeA-Tang wants to merge 7 commits intocrossbeam-rs:masterfrom
Open
skiplist: a new iteator which is sendable among threads#1091SpadeA-Tang wants to merge 7 commits intocrossbeam-rs:masterfrom
SpadeA-Tang wants to merge 7 commits intocrossbeam-rs:masterfrom
Conversation
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
taiki-e
reviewed
Mar 5, 2024
crossbeam-skiplist/src/base.rs
Outdated
| /// A lock-free skip list. | ||
| pub struct ConcurrentSkipList<K, V> { | ||
| /// The underlying skip list | ||
| list: Arc<SkipList<K, V>>, |
Member
There was a problem hiding this comment.
I think we could add a method that takes self: Arc<Self> instead of creating a new type. Like:
Author
There was a problem hiding this comment.
Thanks for the reply. It's a bit late here, I will see it tomorrow.
Author
There was a problem hiding this comment.
I have modified the code. PTAL again, thanks @taiki-e . If this is desired, I will add more tests.
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
taiki-e
reviewed
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #1090
This PR implements a wrapper of the skiplist which supports creating iteator that is sendable among threads.
More tests or comment can be added if this is needed.