Fix CI failure #1196
Open
Fix CI failure #1196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
error: implicit autoref creates a reference to the dereference of a raw pointer
--> crossbeam-skiplist/src/base.rs:2074:28
|
2074 | let next = (*self.node).tower[0].load(Ordering::Relaxed, epoch::unprotected());
| ^^---------^^^^^^^^^^
| |
| this raw pointer has type `*mut Node<K, V>`
|
= note: creating a reference requires the pointer target to be valid and imposes aliasing requirements
note: autoref is being applied to this expression, resulting in: `&Tower<K, V>`
--> crossbeam-skiplist/src/base.rs:2074:28
|
2074 | let next = (*self.node).tower[0].load(Ordering::Relaxed, epoch::unprotected());
| ^^^^^^^^^^^^^^^^^^
= note: `-D dangerous-implicit-autorefs` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dangerous_implicit_autorefs)]`
help: try using a raw pointer method instead; or if this reference is intentional, make it explicit
|
2074 | let next = (&(*self.node).tower)[0].load(Ordering::Relaxed, epoch::unprotected());
| ++ +
error: implicit autoref creates a reference to the dereference of a raw pointer
--> crossbeam-skiplist/src/base.rs:2105:28
|
2105 | let next = (*self.node).tower[0].load(Ordering::Relaxed, epoch::unprotected());
| ^^---------^^^^^^^^^^
| |
| this raw pointer has type `*mut Node<K, V>`
|
= note: creating a reference requires the pointer target to be valid and imposes aliasing requirements
note: autoref is being applied to this expression, resulting in: `&Tower<K, V>`
--> crossbeam-skiplist/src/base.rs:2105:28
|
2105 | let next = (*self.node).tower[0].load(Ordering::Relaxed, epoch::unprotected());
| ^^^^^^^^^^^^^^^^^^
help: try using a raw pointer method instead; or if this reference is intentional, make it explicit
|
2105 | let next = (&(*self.node).tower)[0].load(Ordering::Relaxed, epoch::unprotected());
| ++ +
```
```
error: use `core::ptr::eq` when comparing raw pointers
--> crossbeam-epoch/src/sync/list.rs:343:17
|
343 | assert!(maybe_e3.unwrap().unwrap() as *const Entry == e3.as_raw());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `core::ptr::eq(maybe_e3.unwrap().unwrap(), e3.as_raw())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq
= note: `-D clippy::ptr-eq` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::ptr_eq)]`
error: use `core::ptr::eq` when comparing raw pointers
--> crossbeam-epoch/src/sync/list.rs:346:17
|
346 | assert!(maybe_e2.unwrap().unwrap() as *const Entry == e2.as_raw());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `core::ptr::eq(maybe_e2.unwrap().unwrap(), e2.as_raw())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq
error: use `core::ptr::eq` when comparing raw pointers
--> crossbeam-epoch/src/sync/list.rs:349:17
|
349 | assert!(maybe_e1.unwrap().unwrap() as *const Entry == e1.as_raw());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `core::ptr::eq(maybe_e1.unwrap().unwrap(), e1.as_raw())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq
error: use `core::ptr::eq` when comparing raw pointers
--> crossbeam-epoch/src/sync/list.rs:382:17
|
382 | assert!(maybe_e3.unwrap().unwrap() as *const Entry == e3.as_raw());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `core::ptr::eq(maybe_e3.unwrap().unwrap(), e3.as_raw())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq
error: use `core::ptr::eq` when comparing raw pointers
--> crossbeam-epoch/src/sync/list.rs:385:17
|
385 | assert!(maybe_e1.unwrap().unwrap() as *const Entry == e1.as_raw());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `core::ptr::eq(maybe_e1.unwrap().unwrap(), e1.as_raw())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq
```
|
Looks like there needs to be a MSRV bump to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is not a problem with TB, the problem with SB is known and not caused by the one pointed by this lint and already has a PR to resolve it.