Implement Unparker::unpark_with_result()#1210
Open
re-xyr wants to merge 2 commits intocrossbeam-rs:masterfrom
Open
Implement Unparker::unpark_with_result()#1210re-xyr wants to merge 2 commits intocrossbeam-rs:masterfrom
Unparker::unpark_with_result()#1210re-xyr wants to merge 2 commits intocrossbeam-rs:masterfrom
Conversation
re-xyr
force-pushed
the
unpark-with-result
branch
from
440311e to
3c170bd
Compare
re-xyr
changed the title
Unparker::unparker_with_result()Unparker::unpark_with_result()
This method is like `Unpark::unpark()`, but also returns the previous state of the token. This change also introduces one new public enum `UnparkResult`.
re-xyr
force-pushed
the
unpark-with-result
branch
from
3c170bd to
171c83a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1209.
Unparker::unpark_with_result()is likeUnpark::unpark(), but also returns the previous state of the token. This change also introduces one new public enumUnparkResult.Some other questions to think about:
unparkto returning a result altogether, then making that breaking change here and now could be less painful than adding an alternative method, migrate the main method, and finally deprecate the alternative method, which is two breaking changes.unpark_with_resultsounds a bit awkward. I can think ofunpark_returningas an alternative, but it sounds as awkward.