Replace iterative capacity growth with next_power_of_two#1216
Open
SaiCharanMarrivada wants to merge 3 commits intocrossbeam-rs:masterfrom
Open
Replace iterative capacity growth with next_power_of_two#1216SaiCharanMarrivada wants to merge 3 commits intocrossbeam-rs:masterfrom
next_power_of_two#1216SaiCharanMarrivada wants to merge 3 commits intocrossbeam-rs:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces an iterative capacity-doubling loop with a direct calculation using next_power_of_two() in the deque's reserve function. This is a straightforward optimization that maintains the same behavior while being more efficient and readable.
Changes:
- Replaced the capacity-doubling loop (lines 337-340 in the original code) with a single call to
(reserve_cap + len).next_power_of_two() - Updated the inline comment to reflect the new approach
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
To ensure that replacing the iterative capacity growth with
Note on Verification Scope: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the capacity-doubling loop with
(reserve_cap + len).next_power_of_two(). Given the existing invariant that capacity is a power of two, the result is identical.