Update Go version and enable pushing to ghcr.io in CI#60
Merged
turkenf merged 1 commit intocrossplane-contrib:mainfrom Feb 24, 2025
Merged
Update Go version and enable pushing to ghcr.io in CI#60turkenf merged 1 commit intocrossplane-contrib:mainfrom
turkenf merged 1 commit intocrossplane-contrib:mainfrom
Conversation
turkenf
force-pushed
the
publish-ghcr
branch
2 times, most recently
from
2b21822 to
7d2baef
Compare
Signed-off-by: Fatih Türken <turkenf@gmail.com>
turkenf
force-pushed
the
publish-ghcr
branch
from
7d2baef to
9b842c7
Compare
sergenyalcin
approved these changes
Feb 24, 2025
Collaborator
sergenyalcin
left a comment
sergenyalcin
left a comment
There was a problem hiding this comment.
Thanks @turkenf LGTM!
jastang
reviewed
Feb 24, 2025
| with: | ||
| registry: ghcr.io | ||
| username: ${{ github.repository_owner }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} |
Member
There was a problem hiding this comment.
i don't have permissions to see the github actions settings, but I assume the default token has been granted package write permissions?
Collaborator
Author
There was a problem hiding this comment.
Yes, a package was released after the PR merge: https://github.com/crossplane-contrib/function-auto-ready/pkgs/container/function-auto-ready
turkenf
changed the title
turkenf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR updates go version to fix the following CVEs and enable pushing to ghcr.io in CI.
Also updated deprecated actions:
actions/upload-artifact=> v3 to v4actions/download-artifact=> v3 to v4I have: