Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(values): Be more precise about possibilities how to set values #189

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

schroeder-paul
Copy link

Description of your changes

Added some info about how the different was to se the values interact. Especially the precedence order.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

No functional changes were made.

Signed-off-by: Paul Schroeder (external expert on behalf of DB Netz) <[email protected]>
@schroeder-paul schroeder-paul marked this pull request as ready for review April 20, 2023 09:53
@schroeder-paul schroeder-paul changed the title doc(values): Be more precise about possibilities how to se values doc(values): Be more precise about possibilities how to set values May 8, 2023
Value string `json:"value,omitempty"`
ValueFrom *ValueFromSource `json:"valueFrom,omitempty"`
}

// ValuesSpec defines the Helm value overrides spec for a Release
type ValuesSpec struct {
// Values literals (precedence order: Values < ValuesFrom < Set)
Copy link
Collaborator

@turkenh turkenh May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Values literals (precedence order: Values < ValuesFrom < Set)
// Values literals (precedence order: ValuesFrom < Values < Set)

I think this should be like the above:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schroeder-paul this comment was resolved, but, I see it not resolved on the PR. Did you forget to push?

Signed-off-by: Paul Schroeder (external expert on behalf of DB Netz) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants