feat: add keycloak_identity_provider_token_exchange_scope_permission#485
Conversation
|
Sorry, will take care of this tomorrow |
|
Please add an e2e test case to cluster/test/cases.txt |
|
still |
|
please make sure the test is self-contained so its easier to debug |
c8dd945 to
cab0b65
Compare
|
its a bit weird that this sometimes happens - but the e2e test looked good and was green twice. |
|
yes... i haven't fully figured it out but it has something to do with the Token Exchange feature. in 26.2.0 the legacy one has been disabled (https://www.keycloak.org/docs/latest/release_notes/index.html#supported-standard-token-exchange). I think the tests are passing for 26.3 and 26.4 because the feature flags are not enabled and because of that Keycloak does nothing... In my keycloak i have to set also there may be a change in terraform-provider-keycloak which influences this. I think i have to setup a local test environment and check the Keycloak server logs for each version. |
|
is the new resource a new feature or something that is around for some time? |
|
The Legacy Token Exchange v1 is there for a long time, as a preview feature, but since 26.2 the new v2 called Standard Token Exchange went from preview to supported. Both can be active at the same time... |
|
Finally got the time to look into it! The issue was that the IDP got deleted before the
|
|
Hi @Breee, can you please approve the worklfow? Many thanks! |
|
Here is the fix for the broken CI tests: #494 |
|
@haarchri or @denniskniep can you have a look please and merge? :) |
|
Hi @goran-rajta , can you rebase main, which now includes your fix of tests? |
Signed-off-by: Goran Rajta <goran.rajta@rewe-group.com>
Signed-off-by: Goran Rajta <goran.rajta@rewe-group.com>
Signed-off-by: Goran Rajta <goran.rajta@rewe-group.com>
Signed-off-by: Goran Rajta <goran.rajta@rewe-group.com>
Signed-off-by: Goran Rajta <goran.rajta@rewe-group.com>
Signed-off-by: Goran Rajta <goran.rajta@rewe-group.com>
52d3988 to
f475a58
Compare
|
@goran-rajta thanks for the contribution |
|
Amazing! Thank you! |
|
Hey @denniskniep, thanks again for the merge but when can I expect this to be released? |
|
release is building, thx! |
Description of your changes
Implement https://registry.terraform.io/providers/keycloak/keycloak/latest/docs/resources/identity_provider_token_exchange_scope_permission
Fixes #482
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested with: