WIP: Add DesiredStateChanged event filter#110
Open
bobh66 wants to merge 1 commit intocrossplane-contrib:mainfrom
Open
WIP: Add DesiredStateChanged event filter#110bobh66 wants to merge 1 commit intocrossplane-contrib:mainfrom
bobh66 wants to merge 1 commit intocrossplane-contrib:mainfrom
Conversation
Signed-off-by: Bob Haddleton <bob.haddleton@nokia.com>
Contributor
Author
|
Further testing has revealed a possible issue with Objects not getting updated properly. I'm investigating. |
Contributor
|
@bobh66 did you find anything here? for example, if an immutable object is attempted changed, provider-kubernetes "spins" very actively trying to reconcile it :( I think this would fix that full event (example): in this case, the randomness is here: ... |
This was referenced Jun 27, 2023
Collaborator
|
@bobh66 do you still want to proceed here? |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Added the DesiredStateChanged EventFilter to the controller to avoid unnecessary reconciliations.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Executed this code in a development cluster doing multiple deployments.