fix: Retry adding finalizers to referenced objects on conflict#372
Open
helderjs wants to merge 1 commit intocrossplane-contrib:mainfrom
Open
fix: Retry adding finalizers to referenced objects on conflict#372helderjs wants to merge 1 commit intocrossplane-contrib:mainfrom
helderjs wants to merge 1 commit intocrossplane-contrib:mainfrom
Conversation
Signed-off-by: Helder Santana <contato@heldersantana.net>
helderjs
requested review from
lsviben,
morningspace,
phisco,
sergenyalcin,
turkenf and
turkenh
as code owners
helderjs
force-pushed
the
fix-references-finalizer-mgm
branch
from
d061f1e to
005efae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This pull request updates the finalizer logic for Object resources and their references in the provider-kubernetes project. It ensures that finalizers are correctly added to both the managed resource and any referenced resources, improving cleanup and dependency handling.
Fixes #371
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
This change has been covered by comprehensive unit tests in internal/controller/object/object_test.go,