Skip to content

Feature: use proxy-url from cluster in kubeconfig if set#387

Open
veith4f wants to merge 4 commits intocrossplane-contrib:mainfrom
veith4f:feature/use_proxyurl_from_kubeconfig
Open

Feature: use proxy-url from cluster in kubeconfig if set#387
veith4f wants to merge 4 commits intocrossplane-contrib:mainfrom
veith4f:feature/use_proxyurl_from_kubeconfig

Conversation

@veith4f
Copy link
Copy Markdown

@veith4f veith4f commented Aug 27, 2025

Description of your changes

Clusters in kubeconfig may have a field proxy-url that needs to be respected to reach the specified endpoints.
Currently, client.go in the provider does not respect this.

struct rest.Config created in client.go offers a field proxy:func(*http.Request) (*url.URL, error) that may be used to this end.

How has this code been tested

Just compile/deploy-local as of now. Want to see if there is interest.

Signed-off-by: Fabian Schütz <fabian.f.schuetz@mercedes-benz.com>
@veith4f
Copy link
Copy Markdown
Author

veith4f commented Aug 27, 2025

Was now successfully deployed, packaged, installed and tested in our environment.

Kubernetes Object was correctly provisioned.

@mcfarlanem
Copy link
Copy Markdown

Compiled, packaged, deployed, installed, and tested provider-kubernetes and provider-helm based on this branch. Everything works as expected with proxy-url in private EKS cluster and without proxy-url in public EKS cluster.

Thanks @veith4f for this work. Can we get this contribution merged?

See #347.

@mcfarlanem
Copy link
Copy Markdown

@veith4f @turkenf it's disappointing we haven't got this contribution merged yet. Since my last post I have literally deployed hundreds of clusters using this. IMHO this is a better solution than using env vars at the pod level, not to mention it taking advantage of core Kubernetes capability.

Co-authored-by: Fatih Türken <103541666+turkenf@users.noreply.github.com>
Fatih Türken's code is unnecessary.
@veith4f
Copy link
Copy Markdown
Author

veith4f commented Mar 28, 2026

How bout it guys. Can we get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants