[GoCyclo] Refactor Azure REST config wrapper: with builder pattern#414
Open
siddimore wants to merge 2 commits intocrossplane-contrib:mainfrom
Open
[GoCyclo] Refactor Azure REST config wrapper: with builder pattern#414siddimore wants to merge 2 commits intocrossplane-contrib:mainfrom
siddimore wants to merge 2 commits intocrossplane-contrib:mainfrom
Conversation
…s, reduces branching inside WrapRESTConfig
siddimore
requested review from
erhancagirici,
lsviben,
morningspace,
phisco,
sergenyalcin,
turkenf,
turkenh and
ulucinar
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR refactors the Azure client’s WrapRESTConfig implementation by refactoring the code into dedicated builder types (servicePrincipalBuilder and workloadIdentityBuilder).
This cleanly separates configuration concerns, simplifies control flow, and lowers the cyclomatic complexity of the exported function.
Added, some internal helper functions to isolate parsing and validation steps.
This change removes the need for the previous nolint:gocyclo directive and aligns the implementation with more idiomatic Go patterns.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Added and ran unit tests for all new helper functions
Verified existing behavior through make reviewable test
Confirmed gocyclo passes without nolint suppression