crossplane v2: namespaced MRs#198
Merged
sergenyalcin merged 6 commits intocrossplane-contrib:mainfrom Aug 28, 2025
Merged
Conversation
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
turkenf
approved these changes
Aug 28, 2025
Collaborator
turkenf
left a comment
There was a problem hiding this comment.
Thank you @sergenyalcin, LGTM
erhancagirici
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Introduce namespaced MRs for crossplane v2 support.
notable changes:
tf.m.upbound.iogroupClusterProviderConfig.tf.m.crossplane.iofor new APIs to refer to a cluster-scoped provider config.spec.providerConfigRefis now acceptskindparameter,ProviderConfigorClusterProviderConfigfor new MRs.spec.providerConfigRefnow defaults toClusterProviderConfigwith namedefaultwhen omitted.spec.publishConnectionDetailsTois removed)Note for reviewers
this PR duplicates most of the controller logic and apis for namespaced MRs with several namespace-specific code modified. A refactoring of types and controllers should follow-up.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Tested locally.