feat: add aws_msk_vpc_connection resource#2020
Open
broach-haggard0m wants to merge 1 commit intocrossplane-contrib:mainfrom
Open
feat: add aws_msk_vpc_connection resource#2020broach-haggard0m wants to merge 1 commit intocrossplane-contrib:mainfrom
broach-haggard0m wants to merge 1 commit intocrossplane-contrib:mainfrom
Conversation
broach-haggard0m
requested review from
erhancagirici,
jastang,
sergenyalcin,
turkenf and
ulucinar
as code owners
Signed-off-by: broach haggard0m <broach-haggard0m@icloud.com>
broach-haggard0m
force-pushed
the
feat/add-msk-vpc-connection
branch
from
a499678 to
9070a92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add
aws_msk_vpc_connectionresource to the kafka provider group.Configure VPCConnection.kafka resource with cross-resource references
for target_cluster_arn, vpc_id, client_subnets and security_groups.
Add example manifests for both cluster-scoped and namespace-scoped
managed resources.
Fixes #2019
I have:
make generateand committed the results (ideally in a separate commit).make check-diff.How has this code been tested
kubectl apply -f package/crds/ --server-sidekubectl explain vpcconnection.spec.forProviderconfirms expected schema (authentication, targetClusterArn, vpcId, clientSubnets, securityGroups) with correct cross-resource referenceskubectl apply --dry-run=serverpasses for VPCConnection and all dependency resources (VPC, subnets, security groups)Awaiting uptest run. Please trigger:
/test-examples="examples/kafka/cluster/v1beta1/vpcconnection.yaml"/test-examples="examples/kafka/namespaced/v1beta1/vpcconnection.yaml"