feat: adding support for aws_timestreaminfluxdb_db resources#2026
feat: adding support for aws_timestreaminfluxdb_db resources#2026matthewgreenwaldagility wants to merge 2 commits intocrossplane-contrib:mainfrom
Conversation
Signed-off-by: Matthew Greenwald <matthew.greenwald@agilityrobotics.com>
|
/test-examples="examples/cluster/timestreaminfluxdb/dbcluster.yaml" |
|
I see uptest failing... Do I just need to add something like this to the 4 examples? metadata:
annotations:
meta.upbound.io/example-id: timestreaminfluxdb/v1beta1/dbinstance
upjet.upbound.io/manual-intervention: This resource references SecurityGroup and Subnet resources from the ec2 provider which are not available during automated testing.
labels:
testing.upbound.io/example-name: example
name: example |
|
Hi @matthewgreenwaldagility thank you very much for submitting this PR. In the example manifests, we are preparing a complete manifest to make test. I mean if the resource that we want to test (root resource) needs a few resources as dependency then we should add them to manifests. Let me sahre a few examples from repo: https://github.com/crossplane-contrib/provider-upjet-aws/blob/main/examples/ec2/cluster/v1beta1/route.yaml. For example Route resource needs RouteTable, InternetGateway and VPC for creation. So we added them to the manifest. For dbcluster one, it seems you need to add some subnets, security group and kubernetes secret. As a side note, the |
|
@sergenyalcin Thank you for the helpful explanation. Understood and that makes sense. |
Signed-off-by: Matthew Greenwald <matthew.greenwald@agilityrobotics.com>
|
@jastang @sergenyalcin Pushed a commit with the dependencies added. Thank you for your time and help. |
Description of your changes
Adds two new Crossplane Managed Resources for Amazon Timestream for InfluxDB:
aws_timestreaminfluxdb_db_instance— manages a single Timestream for InfluxDB DB instanceaws_timestreaminfluxdb_db_cluster— manages a Timestream for InfluxDB read-replica clusterBoth are Terraform Plugin Framework resources using frameworkNameAsIdentifier() for external name configuration. Cross-resource references are configured for vpc_subnet_ids → aws_subnet and vpc_security_group_ids → aws_security_group. Cluster-scoped and namespaced variants are included.
Fixes #1569
I have:
How has this code been tested
make -j2 test) not run due to pre-existing Go toolchain version mismatch (go1.25.8 vs go1.25.7); CI should validate