Use commenter's repository permissions instead of author association#751
Merged
turkenf merged 1 commit intocrossplane-contrib:mainfrom Mar 13, 2025
Merged
Use commenter's repository permissions instead of author association#751turkenf merged 1 commit intocrossplane-contrib:mainfrom
turkenf merged 1 commit intocrossplane-contrib:mainfrom
Conversation
Signed-off-by: Fatih Türken <turkenf@gmail.com>
jastang
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Determine appropriate access for comment-based workflow triggers based on the commenter's repository-level permission, rather than author association (which is a non-intuitive derivation based on membership in the GitHub organization in addition to repository-level permissions).
This aims to ensure trusted actors are able to run their e2e workflows in repositories they maintain, without necessarily requiring membership in the crossplane-contrib organization.
xref crossplane-contrib/provider-upjet-azuread#208
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Tested on given ref repository.