Skip to content

Bump Terraform provider version to v5.45.2#756

Merged
turkenf merged 1 commit intocrossplane-contrib:mainfrom
sslavic:stevo-tf-gprov
May 7, 2025
Merged

Bump Terraform provider version to v5.45.2#756
turkenf merged 1 commit intocrossplane-contrib:mainfrom
sslavic:stevo-tf-gprov

Conversation

@sslavic
Copy link
Copy Markdown
Contributor

@sslavic sslavic commented Mar 15, 2025

Copy link
Copy Markdown
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sslavic,

Thanks for your first contribution. To properly upgrade the terraform provider, we also need to update the hashicorp/terraform-provider-google dependency. Please see this PR: #641

@sslavic sslavic requested a review from turkenf March 17, 2025 17:10
@turkenf
Copy link
Copy Markdown
Collaborator

turkenf commented Mar 18, 2025

@sslavic, could you please run go mod tidy and make generate and then push the changes?

Signed-off-by: Stevo Slavic <sslavic@gmail.com>
@turkenf
Copy link
Copy Markdown
Collaborator

turkenf commented Mar 18, 2025

/test-examples="examples/cloudplatform/v1beta1/serviceaccount.yaml"

@turkenf
Copy link
Copy Markdown
Collaborator

turkenf commented Mar 18, 2025

/test-examples="examples/storage/v1beta2/bucket.yaml"

@turkenf
Copy link
Copy Markdown
Collaborator

turkenf commented Mar 18, 2025

/test-examples="examples/spanner/v1beta1/instance.yaml"

@turkenf
Copy link
Copy Markdown
Collaborator

turkenf commented Mar 18, 2025

/test-examples="examples/container/v1beta2/nodepool.yaml"

@turkenf
Copy link
Copy Markdown
Collaborator

turkenf commented Mar 18, 2025

Hey @sslavic,

Thanks again for this contribution—I really appreciate it! 🙏 I ran some automated tests, and everything seems to be working fine. Before we move forward, could you run a manual test to confirm that the issue you mentioned is resolved? It would also be great if you could share your test results with us.

Thanks in advance! 😊

@turkenf
Copy link
Copy Markdown
Collaborator

turkenf commented Apr 29, 2025

/test-examples="examples/container/v1beta2/cluster.yaml"

Copy link
Copy Markdown
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am moving this forward because this PR has made a patch version upgrade in the tf provider and there is no change in the API files. We can close the mentioned issue after testing it.

@turkenf turkenf merged commit fea8bdb into crossplane-contrib:main May 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Recent GCP Release causing GKE Nodepools to reconcile repeatedly (Infinite Loop)

2 participants