Skip to content

chore(): add google cloud run service iam policy#762

Closed
dark-enstein wants to merge 2 commits intocrossplane-contrib:mainfrom
dark-enstein:feat/google_cloud_run_service_iam_policy
Closed

chore(): add google cloud run service iam policy#762
dark-enstein wants to merge 2 commits intocrossplane-contrib:mainfrom
dark-enstein:feat/google_cloud_run_service_iam_policy

Conversation

@dark-enstein
Copy link
Copy Markdown

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

@turkenf
Copy link
Copy Markdown
Collaborator

turkenf commented Mar 26, 2025

Hi @dark-enstein,

Thank you for your interest and effort. The resource you are trying to add, google_cloud_run_service_iam_policy, is on the skip list due to this issue and therefore the make generate command does not create any diff. Since there is a resource of iam_member in this service, we do not prefer to add it with iam_policy.

Also, as I see in our Slack conversation, the resource you wanted to add is google_cloud_run_v2_service_iam_policy. Since there is no iam_* resource in the v2 service, you can add this resource. Please feel free to ask any further questions.

Thanks.

@dark-enstein
Copy link
Copy Markdown
Author

Thanks for this information @turkenf, closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants