Skip to content

Configure Remnant AppEngine resources#768

Closed
dark-enstein wants to merge 12 commits intocrossplane-contrib:mainfrom
dark-enstein:main
Closed

Configure Remnant AppEngine resources#768
dark-enstein wants to merge 12 commits intocrossplane-contrib:mainfrom
dark-enstein:main

Conversation

@dark-enstein
Copy link
Copy Markdown

@dark-enstein dark-enstein commented Apr 8, 2025

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

I run Uptest locally with make e2e by setting those env variables:

export UPTEST_EXAMPLE_LIST="examples/appengine/v1beta1/<resource>.yaml"
export UPTEST_GCP_PROJECT="my-gcp-project"
export UPTEST_CLOUD_CREDENTIALS="gcp-sa-creds" 

The result of this tests was :

  • FlexibleApp Version
FlexibleAppVersion-SuccessE2E
  • DomainMapping
DomainMapping - SuccessE2E
  • ServicesSplitTraffic (⚠️ in progress)

@turkenf
Copy link
Copy Markdown
Collaborator

turkenf commented Apr 8, 2025

/test-examples="examples/appengine/v1beta1/servicesplittraffic.yaml"

@turkenf
Copy link
Copy Markdown
Collaborator

turkenf commented Apr 8, 2025

/test-examples="examples/appengine/v1beta1/flexibleappversion.yaml"

@turkenf
Copy link
Copy Markdown
Collaborator

turkenf commented Apr 8, 2025

/test-examples="examples/appengine/v1beta1/domainmapping.yaml"

@turkenf
Copy link
Copy Markdown
Collaborator

turkenf commented Apr 10, 2025

Hi @dark-enstein, congrats on your first contribution! 🎉

From what I can see, some of the uptests have failed — likely due to issues like invalid examples. As a next step, I’d recommend testing the resources manually to move things forward.

Thanks in advance! 🙏

@dark-enstein
Copy link
Copy Markdown
Author

Hey @turkenf, thanks for your review. I'll perform manual tests and revert.

@dark-enstein
Copy link
Copy Markdown
Author

Can we please commence an e2e test for the /test-examples="examples/appengine/v1beta1/flexibleappversion.yaml" and /test-examples="examples/appengine/v1beta1/domainmapping.yaml"?

@jeanduplessis
Copy link
Copy Markdown
Collaborator

/test-examples="examples/appengine/v1beta1/domainmapping.yaml"

@github-actions
Copy link
Copy Markdown

This provider repo does not have enough maintainers to address every pull request. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions Bot added the stale label Aug 26, 2025
@github-actions
Copy link
Copy Markdown

This pull request is being closed since there has been no activity for 14 days since marking it as stale. If you're still working on this, feel free to reopen the PR or create a new one!

@github-actions github-actions Bot closed this Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants