compute: fix FirewallPolicy observe by correcting identifier resolution#875
Open
AndresAbdo wants to merge 2 commits intocrossplane-contrib:mainfrom
Open
compute: fix FirewallPolicy observe by correcting identifier resolution#875AndresAbdo wants to merge 2 commits intocrossplane-contrib:mainfrom
AndresAbdo wants to merge 2 commits intocrossplane-contrib:mainfrom
Conversation
Derive google_compute_firewall_policy name from the last segment of crossplane.io/external-name and omit name from spec to avoid conflicts. Fixes Observe failures reported in crossplane-contrib#820. Signed-off-by: Andres Abdo <andresabdo23@gmail.com>
Regenerate provider APIs and CRDs after FirewallPolicy identifier changes. This commit includes: - Removal of the deprecated/omitted FirewallPolicy `name` observation field, as it is no longer present in the Terraform provider schema or is represented via external-name semantics. - Updated deepcopy and CRD schemas produced by make reviewable. No functional changes beyond generated output. Signed-off-by: Andres Abdo <andresabdo23@gmail.com>
AndresAbdo
requested review from
erhancagirici,
jastang,
sergenyalcin,
turkenf and
ulucinar
as code owners
|
This provider repo does not have enough maintainers to address every pull request. Since there has been no activity in the last 90 days it is now marked as |
Author
|
/fresh please keep this pull request open. This is a real issue which impacts the ability to observe existing FirewallPolicy resources. @sergenyalcin @turkenf @jastang @ulucinar @erhancagirici If one of you could please review this pull request, it would be greatly appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes observe failures for
ComputeFirewallPolicyresources caused byincorrect identifier resolution during observe.
When the identifier was not constructed correctly, the provider issued a list
request instead of a direct get, which resulted in a 400 error due to a missing
parentId. This change ensures the correct identifier is used so observe callstarget the proper get endpoint.
This PR also includes regenerated APIs and CRDs produced by
make reviewable.As part of regeneration, the
FirewallPolicynameobservation field wasremoved, since it is no longer exposed by the Terraform provider schema and is
represented via external-name semantics.
Fixes #820
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
make local-deployproduction code fails