fix: ignore 'type' field during late initialization for IAM user support#896
Open
fahedouch wants to merge 1 commit intocrossplane-contrib:mainfrom
Open
fix: ignore 'type' field during late initialization for IAM user support#896fahedouch wants to merge 1 commit intocrossplane-contrib:mainfrom
fahedouch wants to merge 1 commit intocrossplane-contrib:mainfrom
Conversation
Signed-off-by: Fahed Dorgaa <fahed.dorgaa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Reproduction
Create a Cloud SQL IAM user with
type: CLOUD_IAM_USER:Wait for the resource to be created (Ready=True)
Check the
typefield in the manifest after a few reconciliation cyclesCurrent behavior: The
typefield becomes empty after reconciliation because the GCP API doesn't return it and LateInitializer resets it. This turns the IAM user into a BUILT_IN user.Expected behavior: The
typefield should persist with the initially specified valueCLOUD_IAM_USER.How to Fix
Adds
LateInitializer.IgnoredFieldsfor the 'type' field in google_sql_user resource to prevent it from being reset to empty during reconciliation. The 'type' field is write-only and not returned by GCP API, causing IAM users (CLOUD_IAM_USER, CLOUD_IAM_SERVICE_ACCOUNT) to be incorrectly converted to BUILT_IN users.Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested