Add support for KeyHandle in KMS module#900
Open
josh-thisisbud wants to merge 1 commit intocrossplane-contrib:mainfrom
Open
Add support for KeyHandle in KMS module#900josh-thisisbud wants to merge 1 commit intocrossplane-contrib:mainfrom
KeyHandle in KMS module#900josh-thisisbud wants to merge 1 commit intocrossplane-contrib:mainfrom
Conversation
… configuration, and examples Signed-off-by: Josh Harwood <josh.harwood@thisisbud.com>
josh-thisisbud
requested review from
erhancagirici,
jastang,
sergenyalcin,
turkenf and
ulucinar
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Attempted to add the KMS Key Handle resource to Crossplane as the majority of the work appears to be automatically generated by Upjet.
I'm mostly looking to get the ball rolling so I apologise if this isn't quite there yet.
Fixes #899
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
I'm not sure how to test providers in Crossplane or Go.