Add a tool to measure the performance characteristics of providers #28
+686
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
sergenyalcin
force-pushed
the
provider-performance-tool
branch
2 times, most recently
from
b1b104f to
c73bd08
Compare
ulucinar
reviewed
Apr 5, 2022
ulucinar
left a comment
ulucinar
left a comment
There was a problem hiding this comment.
Hi @sergenyalcin,
Could you please add the following to golangci/golangci-lint-action@v2 configuration:
skip-go-installation: true
For more context, please see:
crossplane-contrib/provider-azure#333
Signed-off-by: Sergen Yalçın <[email protected]>
sergenyalcin
force-pushed
the
provider-performance-tool
branch
from
c73bd08 to
e146dda
Compare
Member
|
I like the look of this tool, but I'm unsure whether this repo is the right place for it. Is the idea that we would begin to consider performance as part of whether a provider is or is not conformant? CC @muvaf who I believe suggested adding this to this repo originally. |
This was referenced Feb 28, 2023
Signed-off-by: Sergen Yalçın <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Related crossplane/crossplane#2979
With this PR, a tool is added to measure the performance characteristics of providers. Details are in the following one-pager draft: crossplane/crossplane#2983
I have:
make reviewable testto ensure this PR is ready for review.