Add a public package for xpkg specification values #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Tang <[email protected]>
jastang
commented
Apr 2, 2025
Comment on lines
+36
to
+43
| XpkgExtension string = ".xpkg" | ||
|
|
||
| // XpkgMatchPattern is the match pattern for identifying compiled Crossplane packages. | ||
| XpkgMatchPattern string = "*" + XpkgExtension | ||
|
|
||
| // XpkgExamplesFile is the name of the file in a Crossplane package image | ||
| // that contains the examples YAML stream. | ||
| XpkgExamplesFile string = ".up/examples.yaml" |
There was a problem hiding this comment.
@adamwg rightfully points out that some of these aren't technically defined by the specification, just often re-declared in other projects and specific implementation details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds a public package for constant values defined by Crossplane's xpkg specification.
ref: https://github.com/crossplane/crossplane/blob/main/internal/xpkg/name.go, which is internal.
I have:
earthly +reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.