Generate namespace-scoped MR example manifest in crossplane-system namespace #120
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
We need to consume upjet from the main branch once crossplane/upjet#535 is in. |
ulucinar
force-pushed
the
fix-example-ns
branch
2 times, most recently
from
4692b33 to
5ec42fd
Compare
erhancagirici
approved these changes
Oct 9, 2025
2 tasks
jeanduplessis
approved these changes
Oct 10, 2025
…mespace - Bump upjet to commit 0b7f640373c8. Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
fix-example-ns
branch
from
5ec42fd to
3254676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Generate namespace-scoped MR's example manifest in
crossplane-systeminstead ofupbound-system. Bump upjet to commit0b7f640373c8to be able to configure the namespace used by the example manifest generation pipeline.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
make generateafter consuming crossplane/upjet#535.