GCW-3407 Gogox Gem Integration and Transport APIs #1195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveyken
reviewed
Jan 13, 2021
swatijadhav
requested review from
steveyken,
bharat619,
patrixr,
abulsayyad123 and
shreyas098
bharat619
reviewed
Jan 21, 2021
bharat619
reviewed
Jan 21, 2021
bharat619
reviewed
Jan 21, 2021
| @time.to_i | ||
| end | ||
|
|
||
| class ValueError < StandardError; end |
There was a problem hiding this comment.
Instead of just value error defining here, create a error in errors.rb
something like TransportationServiceError
bharat619
reviewed
Jan 21, 2021
bharat619
reviewed
Jan 21, 2021
Co-authored-by: bharat619 <[email protected]>
steveyken
requested changes
Jan 28, 2021
| end | ||
|
|
||
| api :POST, '/v1/transports/update_hook', "Webhook to update transport status" | ||
| def update_hook |
There was a problem hiding this comment.
When implemented, we should use our own authorization check here. E.g. webhook can be /api/v1/transports/update_hook?shared_key=ds23f934dfs¶m1=df¶m2=23
Then check shared_key is as expected.
steveyken
requested changes
Feb 10, 2021
| status: response["status"], | ||
| scheduled_at: Time.at(response["pickup"]["schedule_at"]).in_time_zone, | ||
| metadata: response, | ||
| source_id: @params[:source_id], |
There was a problem hiding this comment.
As noted in the controller, this is where source_id and source_type is being overridden by user params rather than the sanitized CanCanCan object. Use @transports instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link:
https://jira.crossroads.org.hk/browse/GCW-3407
What does this PR do?
Gogox Gem Integration and Transport APIs
NOTE: webhook implementation is still WIP