feat: add keypad key support for numeric keypads #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the solution requested in crossterm-rs#860 by adding distinct KeyCode enum variants for numeric keypad keys, allowing applications to differentiate between main keyboard numbers and keypad numbers. New KeyCode variants added: - Keypad0-9: Numeric keypad keys - KeypadMultiply (*), KeypadPlus (+), KeypadMinus (-), KeypadDivide (/): Operators - KeypadPeriod (.), KeypadComma (,), KeypadEqual (=), KeypadEnter: Additional keys Platform implementations: - Unix: Parses DECKPAM (DEC Keypad Application Mode) escape sequences with modifiers (Shift, Alt, Ctrl, and combinations) using the standard xterm modifier encoding (ESC O <modifier> <key>). Also extends modifier support to existing ESC O sequences (arrows, Home, End, F1-F4). - Windows: Maps VK_NUMPAD virtual key codes to the new KeyCode variants. Usage of modifier + numpad varies on Windows. A number of those combinations are already in use by Windows, so they are of limited practicality. Closes crossterm-rs#860
…mmands
Refactors DECKPAM modifier parsing to use the existing parse_modifiers()
function for consistency with CSI sequences, rather than duplicating the
modifier extraction logic with a manual match statement. The ASCII digit
modifier code ('2'-'8') is converted to its numeric value (2-8) before
passing to parse_modifiers().
Adds EnableApplicationKeypad and DisableApplicationKeypad commands to
allow applications to control DECKPAM mode, following the same pattern
as other terminal mode commands (EnableMouseCapture, EnableFocusChange,
etc.). This makes the keypad feature complete and discoverable without
requiring users to know raw escape sequences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the solution requested in #860 by adding distinct
KeyCode enum variants for numeric keypad keys, allowing applications
to differentiate between main keyboard numbers and keypad numbers.
New KeyCode variants added:
Platform implementations:
Closes #860