Refactor KeyCode & ModifierKeyCode to new modules
#1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
reviewed
Nov 17, 2025
Collaborator
There was a problem hiding this comment.
Thanks - this has been on my someday list to do as I prefer smaller files that reduce the cognitive load too.
Can you please move the impl blocks and unit tests too?
Also feel free to do Mouse in this same PR if you'd like - it needs to happen in the same sometime bucket.
Contributor
Author
|
I moved the mouse event, mouse event kind, and mouse button structures to their own file, and moved the applicable tests for key codes and modifiers to their respective modules. Are there any other |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #998.
This PR migrates
KeyCodeandModifierKeyCodeto new modules, which reduces the LoC inevent.rsand makes the code a bit more friendly.