refactor: use is_key_*
helpers for consistency in key event methods
#980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors
as_key_release_event
andas_key_repeat_event
to use the existingis_key_release
andis_key_repeat
helper methods for consistency. This aligns allas_key_*_event
methods to follow the same structure, improving maintainability.Changes
as_key_release_event
now callsis_key_release()
instead of manually checkingevent.kind == KeyEventKind::Release
as_key_repeat_event
now callsis_key_repeat()
instead of manually checkingevent.kind == KeyEventKind::Repeat
Rationale
is_key_press_event
already usesis_key_press()
, so the other two methods should follow the same pattern.matches!
macro used inis_key_*
functions is more general and can sometimes be optimized better by the compiler.