Decrease the amount of node saves #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebase of PR crowbar#80 Only save the node when attribute(s) have changed Do not fetch monitor secret if we're the master
houndci-bot
reviewed
Aug 2, 2017
| dirty = true | ||
| end | ||
| # if journal_device is nil, this will still work as expected | ||
| if node["ceph"]["osd_devices"][index]["journal"] != journal_device |
There was a problem hiding this comment.
Metrics/BlockNesting: Avoid more than 3 levels of block nesting. (https://github.com/bbatsov/ruby-style-guide#three-is-the-number-thou-shalt-count)
| end | ||
| node.set["ceph"]["osd_devices"][index]["status"] = "deployed" | ||
| node.set["ceph"]["osd_devices"][index]["journal"] = journal_device unless journal_device.nil? | ||
| if node["ceph"]["osd_devices"][index]["status"] != "deployed" |
There was a problem hiding this comment.
Metrics/BlockNesting: Avoid more than 3 levels of block nesting. (https://github.com/bbatsov/ruby-style-guide#three-is-the-number-thou-shalt-count)
|
|
||
| node.set["ceph"]["osd"]["use_ssd_for_journal"] = false unless has_ssds && has_hdds | ||
| use_ssd_for_journal = has_ssds && has_hdds | ||
| if node["ceph"]["osd"]["use_ssd_for_journal"] != use_ssd_for_journal |
There was a problem hiding this comment.
Metrics/BlockNesting: Avoid more than 3 levels of block nesting. (https://github.com/bbatsov/ruby-style-guide#three-is-the-number-thou-shalt-count)
| if !node["ceph"]["osd"]["journal_devices"].empty? | ||
| node.set["ceph"]["osd"]["use_ssd_for_journal"] = false | ||
| # explicit comparison because we don't want a condition that uses nil | ||
| if node["ceph"]["osd"]["use_ssd_for_journal"] != false |
There was a problem hiding this comment.
Metrics/BlockNesting: Avoid more than 3 levels of block nesting. (https://github.com/bbatsov/ruby-style-guide#three-is-the-number-thou-shalt-count)
nicolasbock
approved these changes
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of PR #80
Only save the node when attribute(s) have changed
Do not fetch monitor secret if we're the master