Skip to content

Conversation

@CKY-
Copy link
Collaborator

@CKY- CKY- commented Nov 13, 2024

Description of the Change

remove trailing carriage return in write to file effect for replace line by text where there is an unexpected "\r" on some files.

Applicable Issues

#2891

Testing

loaded a file with

54 65 73 74 20 41 72 67 75 6D 65 6E 74 3A 20 33 0D 0A 
54 65 73 74 20 41 72 67 75 6D 65 6E 74 3A 20 31 0D 0A
54 65 73 74 20 41 72 67 75 6D 65 6E 74 3A 20 32 0D 0A
54 65 73 74 20 41 72 67 75 6D 65 6E 74 3A 20 39 0D 0A 
54 65 73 74 20 41 72 67 75 6D 65 6E 74 3A 20 34 0D 0A
Test Argument: 3
Test Argument: 1
Test Argument: 2
Test Argument: 5
Test Argument: 4

replaced Test Argument: 5 with Test Argument: 9

54 65 73 74 20 41 72 67 75 6D 65 6E 74 3A 20 33 0A
54 65 73 74 20 41 72 67 75 6D 65 6E 74 3A 20 31 0A 
54 65 73 74 20 41 72 67 75 6D 65 6E 74 3A 20 32 0A 
54 65 73 74 20 41 72 67 75 6D 65 6E 74 3A 20 39 0A 
54 65 73 74 20 41 72 67 75 6D 65 6E 74 3A 20 34 0A
Test Argument: 3
Test Argument: 1
Test Argument: 2
Test Argument: 9
Test Argument: 4

as expected all carriage returns (0D) where removed

Screenshots

{1C0ED40D-893C-4024-A862-DD49B14AADA1}

@CKY- CKY- requested a review from ebiggz as a code owner November 13, 2024 20:45
@CKY- CKY- changed the title V5 remove carriage return in write to file effect fix: remove carriage return in write to file effect Nov 15, 2024
@heyaapl heyaapl enabled auto-merge (squash) November 19, 2024 01:48
@heyaapl heyaapl merged commit 729acc4 into crowbartools:v5 Nov 19, 2024
1 check passed
@CKY- CKY- deleted the v5-remove-cr-in-file-effect branch January 1, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants